Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add tag to publish log message #5494

Merged
merged 1 commit into from Sep 14, 2022
Merged

fix: add tag to publish log message #5494

merged 1 commit into from Sep 14, 2022

Conversation

wraithgar
Copy link
Member

@wraithgar wraithgar commented Sep 12, 2022 •
edited 

npm notice Publishing to https://registry.npmjs.org/ with tag latest (dry-run)

@wraithgar wraithgar requested a review from a team as a code owner September 12, 2022 16:03
@npm-cli-bot
Copy link
Collaborator

npm-cli-bot commented Sep 12, 2022 •
edited

found 20 benchmarks with statistically significant performance improvements

  • app-large: clean, lock-only, cache-only, cache-only:peer-deps, modules-only, no-lock, no-cache, no-modules, no-clean, no-clean:audit
  • app-medium: clean, lock-only, cache-only, cache-only:peer-deps, modules-only, no-lock, no-cache, no-modules, no-clean, no-clean:audit
timing results
app-large clean lock-only cache-only cache-only
peer-deps		 modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 47.556 ±3.46 20.854 ±0.20 18.889 ±0.28 22.644 ±2.62 3.361 ±0.03 3.416 ±0.06 2.816 ±0.01 12.790 ±0.08 2.718 ±0.05 3.791 ±0.02
#5494 0.117 ±0.00 0.114 ±0.00 0.121 ±0.00 0.116 ±0.00 0.123 ±0.01 0.120 ±0.00 0.115 ±0.00 0.118 ±0.00 0.116 ±0.00 0.122 ±0.00
app-medium clean lock-only cache-only cache-only
peer-deps		 modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 30.834 ±1.19 15.769 ±0.02 13.925 ±0.00 16.438 ±1.15 2.954 ±0.01 2.977 ±0.04 2.781 ±0.08 9.516 ±0.07 2.520 ±0.02 3.669 ±0.03
#5494 0.117 ±0.00 0.117 ±0.00 0.121 ±0.00 0.125 ±0.00 0.120 ±0.00 0.117 ±0.01 0.120 ±0.00 0.120 ±0.00 0.124 ±0.00 0.120 ±0.00

@lukekarrys
Copy link
Contributor

Good (and very helpful) catch!

ljharb
ljharb reviewed Sep 12, 2022
View reviewed changes
tap-snapshots/test/lib/commands/publish.js.test.cjs
@@ -51,7 +51,7 @@ Array [
],
Array [
"",
"Publishing to https://registry.npmjs.org/ (dry-run)",
"Publishing to https://registry.npmjs.org/ with tag latest (dry-run)",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can the tag names be quoted or backticked?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can update that in a subsequent PR

@fritzy fritzy merged commit 1fa8e3f into latest Sep 14, 2022
@fritzy fritzy deleted the gar/publish-log-tag branch September 14, 2022 21:52
@github-actions github-actions bot mentioned this pull request Sep 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb left review comments

@fritzy fritzy fritzy left review comments

@lukekarrys lukekarrys lukekarrys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@wraithgar @npm-cli-bot @lukekarrys @ljharb @fritzy